Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Rebar3 plugin debug logging #532

Merged
merged 2 commits into from
May 2, 2023

Conversation

erszcz
Copy link
Collaborator

@erszcz erszcz commented Apr 28, 2023

This should help in cases like @ilya-klyuchnikov's #530, where it's not clear what options the Rebar3 plugin runs Gradualizer with and on what files. We have to use DEBUG=1 rebar3 gradualizer to see the debug printouts.

@erszcz erszcz requested a review from zuiderkwast April 28, 2023 14:32
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@@ -91,7 +91,7 @@ To run Gradualizer from rebar3, add it as a plugin in your `rebar.config`:

```erlang
{plugins, [
{gradualizer, {git, "git@github.com:josefs/Gradualizer.git", {branch, "master"}}}
{gradualizer, {git, "https://github.com/josefs/Gradualizer.git", {branch, "master"}}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git:// scheme was dropped completely by GitHub, so I wanted to update the docs. On the occasion it doesn't hurt to unify all the examples to use the same scheme.

Copy link
Collaborator

@zuiderkwast zuiderkwast Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git@github.com was not dropped. Only git:// (without username) was dropped IIUC.

src/rebar_prv_gradualizer.erl Show resolved Hide resolved
@erszcz erszcz merged commit 2a73a6b into josefs:master May 2, 2023
@erszcz erszcz deleted the rebar-debug-logging branch May 2, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants