Disallow timeouts in tests #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a `should_fail` test timed out, it was considered as a success, even though it proably shouldn't as it usually means there's a bug in the typechecker.
…oblems Type-checking of the functions recursive_param1 and recursive_param3 was timing out. There is probably still some infinite loop that is not handled.
|
Well spotted, thanks @xxdavid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
should_failtest timed out, it was considered as a success, even though it proably shouldn't as it usually means there's a bug in the typechecker. I've changed it.Unfortunately, it turned out that there are probably still some infinite loops that are not handled, as after this change two test cases that used recursive types started failing. I've moved them to known problems.