Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTML API to data-bp-*? #6

Open
tomByrer opened this issue Dec 10, 2014 · 2 comments
Open

Change HTML API to data-bp-*? #6

tomByrer opened this issue Dec 10, 2014 · 2 comments

Comments

@tomByrer
Copy link

Data attributes are starting to be used more & more. To help prevent conflicting with another JS script, could you please add a "namespace"? EG: data-bp-x for "BigPicture X position"? Or data-bpx or data-bp_x...

Please don't make the internet crash with data-x! (OK, I joke)

@josephernest
Copy link
Owner

Hi @tomByrer, thanks for your idea! :) I'm currently thinking about probably better names for the attributes.
By the way, do you have any example in mind of library (that would be used together with bigpicture.js) that would conflict with data-x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants