Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC-63: Org API Fit and Finish #59

Open
joshchu opened this issue Feb 1, 2021 · 3 comments
Open

DC-63: Org API Fit and Finish #59

joshchu opened this issue Feb 1, 2021 · 3 comments

Comments

@joshchu
Copy link
Owner

joshchu commented Feb 1, 2021

[file id="2af8d55f-6909-46a9-b3b1-f43d5a4fb250"][file id="9eef4c01-1cb7-4f62-891a-a16bd712390b"]
The following items may need to be fleshed out on backend before functionality in the frontend as pictured.

Role Revocation- In the context of the UI it makes sense for Roles to be toggles. This perhaps comes with an understanding that “removing all of a user’s roles effectively removes that user from the org.” Not sure if that makes sense from backend perspective.

Add Member- Confirming that this only applies to existing DC user emails? Re: item 1, we should also have a means of removing member. Be it through complete role revocation, or an explicit “remove member from org” action.

Create Organization- I would like if there were also a “remove org” function. This may be too dangerous to actually expose on the UI. So it’s just a nice cleanup function to have for my own testing on development.

Org Logos- Right now this is just a hard coded mapping, but it would be nice if a file could be uploaded on org creation and a signed url were returned in list_organizations

Org Restrictions- Restrictions (as seen in org settings modal) should be returned in the organization list. And as discussed with Josh we should also have a mutation for creating/editing these restrictions.

Copy link
Owner Author

joshchu commented Feb 1, 2021

Muhammad Arafat commented in Jira:

This perhaps comes with an understanding that “removing all of a user’s roles effectively removes that user from the org.” Not sure if that makes sense from backend perspective.

This is correct from the BE point of view as well.

Copy link
Owner Author

joshchu commented Feb 1, 2021

Muhammad Arafat commented in Jira:

https://github.com/DriverTechnologies/cloud-driver/pull/122Knocks down a couple of requested changes from above, leaving numbers 4 and 5 for a future PR

Copy link
Owner Author

joshchu commented Feb 1, 2021

Muhammad Arafat commented in Jira:

https://github.com/DriverTechnologies/cloud-driver/pull/124adds support to organization level filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant