Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

ui/list: do not use data-joshfire-child #50

Open
dieppe opened this issue Jan 15, 2014 · 0 comments
Open

ui/list: do not use data-joshfire-child #50

dieppe opened this issue Jan 15, 2014 · 0 comments

Comments

@dieppe
Copy link
Contributor

dieppe commented Jan 15, 2014

line 434:

var lastOffset = itemContainer.children().last().data('joshfire-child');

should be replaced (why not use this.items.length ?)

line 578:

var el = container.find('> ' + tagName + '[data-joshfire-child=' + offset + ']')[0];

should read something like

var el = container.find('> ' + tagName + ':eq(' + offset + ')')[0];
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant