-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the reactify transform from package.json #11
Comments
Hi @mvila, thanks for the heads-up. I believe this is due to the browserify field in package.json, which instructs browserify what transforms to use: https://github.com/joshwnj/react-visibility-sensor/blob/master/package.json#L34-L40 In the most recent version I've moved reactify from |
I have not tested yet but I think it should work. However, this is not great to include |
Sure, I'll have a look at what some other react components are doing and see if there's a "best practice" to adopt here. The advantage of including |
I understand the advantage of the |
@mvila sorry for the delay - you make a good point and we'll be removing the |
This is resolved in v3.0.0 |
Since I replaced reactify by babelify, I get the following error when I try to browserify my project using your module:
Error: Cannot find module 'reactify' from '/Users/mvila/Projects-next/avc-online/node_modules/react-visibility-sensor'
I think you should remove the reactify transform from your package.json and find another way to reactify your tests/examples.
The text was updated successfully, but these errors were encountered: