Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 support #393

Open
cristiancirstea opened this issue Feb 9, 2021 · 6 comments
Open

React 17 support #393

cristiancirstea opened this issue Feb 9, 2021 · 6 comments
Assignees

Comments

@cristiancirstea
Copy link

Is it possible to update the peer dependencies to allow using react 17?

"react": "^15.3.0 || ^16.2.0",

@davwheat
Copy link
Collaborator

davwheat commented Feb 9, 2021

@w01f6 You shouldn't be using this package anymore as it's very broken, but, just for you, I'll do it :)

@davwheat
Copy link
Collaborator

davwheat commented Feb 9, 2021

@w01f6 Published 1.2.0-beta.1. Give it a go and let me know if you have any issues.

@davwheat davwheat self-assigned this Feb 9, 2021
@amirhar
Copy link
Contributor

amirhar commented Feb 12, 2021

Just tried it get an import error
error - ./node_modules/react-images/dist/react-images.es.js
Attempted import error: 'react-full-screen' does not contain a default export (imported as 'Fullscreen').

Looks like its just a typo in the module import? Added a PR

@davwheat
Copy link
Collaborator

davwheat commented Feb 13, 2021

@amirhar Published 1.2.0-beta.3!

@TheOneAndOnlyGarcia
Copy link

this issue: seems co-related to the current beta path: #396

@qiutian00
Copy link

@w01f6 You shouldn't be using this package anymore as it's very broken, but, just for you, I'll do it :)

great !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants