Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for URLs #32

Closed
mariofix opened this issue Nov 30, 2022 · 1 comment
Closed

Suggestion for URLs #32

mariofix opened this issue Nov 30, 2022 · 1 comment

Comments

@mariofix
Copy link

Hello, I'm trying your app and I noticed it creates a few routes /statics, /api/{identity}, they get added at the root.

INFO: 127.0.0.1:41598 - "GET /user/list HTTP/1.1" 200 OK
INFO: 127.0.0.1:41598 - "GET /api/user?skip=0&limit=10 HTTP/1.1" 200 OK
INFO: 127.0.0.1:56438 - "GET /api/user?skip=0&limit=10 HTTP/1.1" 200 OK

I believe they should be added after base_url=/admin so the URL always has /admin prepended.
I was about to make the fork and then the PR but I noticed you're about lo launch a new release, are you considering making this modification? I can make it if you didn't consider it for the new release.

@jowilf
Copy link
Owner

jowilf commented Nov 30, 2022

Hello,
starlette-admin create a mounted app into your original app with base_url as base root path.

It won't be visible in log due to this issue in starlette itself ->
encode/starlette#1336

Thank you.

@jowilf jowilf closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants