This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
remove http.cat #1447
Labels
Comments
I approve. Yes, the biggest change is to update all the unit tests. If we really want to remove this from the API, we could move it into tests/common.js. |
ideally, all of the tests hit our real HTTP API. http.cat as the only thing I didn't shim in the re-write of the client because it was going to be deprecated anyway. |
LGTM |
can we get this merged? |
Thanks, merged in 584ae7b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
http.cat has been noted as needing to be deprecated for a while.
at the moment, it's an entire different code path from the rest of the http client logic.
the biggest task when removing it is just getting the unittests to stop using it.
@isaacs @ry
The text was updated successfully, but these errors were encountered: