Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Can't use mutable header APIs after sent. #752

Closed
tj opened this issue Mar 6, 2011 · 3 comments
Closed

Can't use mutable header APIs after sent. #752

tj opened this issue Mar 6, 2011 · 3 comments

Comments

@tj
Copy link

tj commented Mar 6, 2011

IMO you should be able to use getHeader() after for reporting etc

@ncb000gt
Copy link

+1 - @ry also said to mention @creationix in the ticket.

@focusaurus
Copy link

Agreed. I have also hit this issue. in http.js OutgoingMessage.getHeader will throw an error if _header is already set, but since this is a read-only API, it's not appropriate. I ran this by ryah in IRC and he agreed this error is probably not needed here. He asked me to mention @creationix in the github issue. The fix is just to delete the clause that raises the error.

@creationix
Copy link

I'm find with removing the check since it's read-only. I was just being conservative in my patch and allowing as little new functionality as possible.

bnoordhuis pushed a commit that referenced this issue Aug 28, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants