This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
In all native modules, require should be called.
#9201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NativeModule system passes `NativeModule.require` transparently there. All other require calls in this module are without `NativeModule.` prefix, these three are last to finally finish what should be done back there when lib/module.js was being extracted. The only one which _should_ have the prefix is the in line 295, where actually implements a big fs-based module system and actually requires a native module. That is left unchanged.
|
Fixes #2009. |
trevnorris
pushed a commit
that referenced
this pull request
Feb 12, 2015
The NativeModule system passes NativeModule.require transparently and so is unnecessary to call explicitly. The only one which should have the prefix is the in line 295, where actually implements a big fs-based module system and actually requires a native module. That is left unchanged. PR-URL: #9201 Ref: #2009 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks. Landed in b8604fa with minor commit message reword. |
ghost
deleted the
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 13, 2015
The NativeModule system passes NativeModule.require transparently and so is unnecessary to call explicitly. The only one which should have the prefix is the in line 295, where actually implements a big fs-based module system and actually requires a native module. That is left unchanged. PR-URL: nodejs/node-v0.x-archive#9201 Ref: nodejs/node-v0.x-archive#2009 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Conflicts: lib/module.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NativeModule system passes
NativeModule.requiretransparently there. All other require calls in this module are withoutNativeModule.prefix, these three are last to finally finish what should be done back there when lib/module.js was being extracted.The only one which should have the prefix is the in line 295, where actually implements a big fs-based module system and actually requires a native module. That is left unchanged.