Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs formatting #320

Closed
bmicklea opened this issue May 17, 2024 · 5 comments · Fixed by #333
Closed

Docs formatting #320

bmicklea opened this issue May 17, 2024 · 5 comments · Fixed by #333
Assignees
Labels
bug Something isn't working

Comments

@bmicklea
Copy link
Contributor

Describe the bug
Both hyperlinks and code snippets are the same color. It would be easier to read if hyperlinks were "brighter" or more noticeable than code snippets for formatting.

To Reproduce
Look at the Install page for a good example.

Version
Latest

@bmicklea bmicklea added the bug Something isn't working label May 17, 2024
@javisperez
Copy link
Contributor

@annigro any color suggestion? this is the install page https://kitops.ml/docs/cli/installation.html

@annigro
Copy link

annigro commented May 28, 2024

Ok, I am not the biggest fan of gold as a highlight color. I would prefer salmon or aero (cool support color we have in our back pocket).
Screenshot 2024-05-28 at 8 32 30 AM
Screenshot 2024-05-28 at 8 32 08 AM
Screenshot 2024-05-28 at 8 33 00 AM

Salmon: #FFA3AF
Aero: #00C3E2

@javisperez
Copy link
Contributor

@bmicklea any preference between Salmon or Aero?

@javisperez
Copy link
Contributor

javisperez commented May 29, 2024

also @annigro i assume that these color changes are for the content links only, not ALL the links, like the top navigation and the sidebar, right?

@bmicklea
Copy link
Contributor Author

I prefer gold or aero. And don't change the color of sidebar highlight or top nav or else we will have just shifted the problem elsewhere :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants