Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling a kit pull with ctrl+c leaves partially downloaded layers in storage #387

Closed
amisevsk opened this issue Jun 27, 2024 · 0 comments · Fixed by #408
Closed

Cancelling a kit pull with ctrl+c leaves partially downloaded layers in storage #387

amisevsk opened this issue Jun 27, 2024 · 0 comments · Fixed by #408
Assignees
Labels
bug Something isn't working

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Jun 27, 2024

Describe the bug
Kit saves partially-downloaded layers to an ingest directory, and moves them into actual storage when the upload is completed. However, it does not clean these files up if the download is killed unexpectedly (e.g. via ctrl-C), leaving those files to consume storage space.

To Reproduce

  1. Begin downloading a modelkit with at least one larger layer
  2. Cancel the download partway through via ctrl+C
  3. Look in <kitops-home>/storage/<repo>/ingest to see partially downloaded tmp files.

It's not clear when these files are cleaned up, and in my testing, even a kit remove -a -f will not remove them.

Version
nightly

Additional context
Related to #311 -- these files could be used to resume downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant