Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brew issues #563

Closed
bmicklea opened this issue Oct 28, 2024 · 9 comments · May be fixed by #523
Closed

Brew issues #563

bmicklea opened this issue Oct 28, 2024 · 9 comments · May be fixed by #523
Assignees
Labels
bug Something isn't working

Comments

@bmicklea
Copy link
Contributor

bmicklea commented Oct 28, 2024

Describe the bug
There are some issues with the kitops.rb file in our brew install:

@bmicklea bmicklea added the bug Something isn't working label Oct 28, 2024
@brett-hodges
Copy link
Contributor

@bmicklea Regarding the first issue: The kitops.rb file is automatically generated by the KitOps build process. Since we (Jozu) haven't built KitOps since before I added the brew install functionality, the kitops.rb file hasn't been updated. When we (Jozu) do build the next version of KitOps, the urls in the kitops.rb file should point to jozu-ai and not brett-hodges.

@bmicklea
Copy link
Contributor Author

@gorkem can we cut a KitOps release today? We've moved Brew into our KitOps docs so I'd like to make sure everything works as expected (it worked for me).

@bmicklea
Copy link
Contributor Author

bmicklea commented Nov 4, 2024

So a new Kit release was cut last week (https://github.com/jozu-ai/kitops/releases/tag/v0.3.4), but the .rb file hasn't changed: https://github.com/jozu-ai/kitops/tree/main/build/homebrew

Are you sure it auto-updates when a new Kit version is built? Did a step fail or skip last week?

@brett-hodges
Copy link
Contributor

There was an issue with the way I was setting an environment variable in the Github Action that builds the .rb file. I made the change last week. @amisevsk Can we push a new release of Kitops to enable the Homebrew installation?

@amisevsk
Copy link
Contributor

amisevsk commented Nov 5, 2024

I believe we're waiting on a couple of PRs to be merged before cutting a new minor release

@bmicklea
Copy link
Contributor Author

bmicklea commented Nov 5, 2024

Can you add links to those so we can stay on top of getting the release cut?

@amisevsk
Copy link
Contributor

amisevsk commented Nov 5, 2024

Since #559 is merged, the last PR is #523 -- I'd like to take a look today and merge it if it's ready, then we can cut a release later today or tomorrow.

@bmicklea bmicklea linked a pull request Nov 5, 2024 that will close this issue
@bmicklea
Copy link
Contributor Author

bmicklea commented Nov 5, 2024

Nice - that will be an impactful release:

  1. New Kit CLI config command and env file
  2. kit dev support for Windows, Linux, and MacOS
  3. Brew install option for Kit CLI
  4. (Stretch) Kit Python libraries (Create KitOps Python libraries #118)

I wouldn't hold the release for (4) but it would make a nice addition.

@brett-hodges
Copy link
Contributor

Closing this issue as the Homebrew bug is fixed as of KitOps v.0.4.0 and a separate Issue has been opened related to creating a Homebrew Cask (See the Issue Description above.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants