Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a docs layer to ModelKits #84

Closed
bmicklea opened this issue Mar 8, 2024 · 4 comments · Fixed by #386
Closed

Add a docs layer to ModelKits #84

bmicklea opened this issue Mar 8, 2024 · 4 comments · Fixed by #386
Assignees
Labels
enhancement New feature or request ModelKit Topics related to ModelKit

Comments

@bmicklea
Copy link
Contributor

bmicklea commented Mar 8, 2024

Describe the problem your feature would solve
It can sometimes be difficult to understand what a model is meant to be used for and what datasets are / why they were included.

Describe the solution you'd like
A readme included in the ModelKit would make it easy for the Kitfile producer and consumer to understand the context for the ModelKit and the assets it is packaging.

Describe alternatives you've considered
Descriptions in the Kitfile are okay, but are either very short and keep the Kitfile readable, or are very long and wreck the readability.

Additional context
[none]

@bmicklea bmicklea added enhancement New feature or request ModelKit Topics related to ModelKit labels Mar 8, 2024
@gorkem
Copy link
Contributor

gorkem commented May 13, 2024

I suggest we turn this into a convention rather than implementation any code section with path README.md that points to the root of the ModelKit should be considered the README. We should document this convention but as far as the implementation we do not need to do any additional work.

@amisevsk
Copy link
Contributor

We might want to consider codifying it more directly. I'm thinking we might want to treat them differently (e.g. store them in a more parseable format) and also ensure they come exported with every model (i.e. not lost when using kit unpack --model)

Maybe something like a modelpart with a specific type (readme)?

@bmicklea
Copy link
Contributor Author

Yes, that's what I was thinking too. Something so that a platform or tool could choose to "highlight" the readme separately - similar to what GitHub, Hugging Face, and others do today with readme.

@gorkem
Copy link
Contributor

gorkem commented May 13, 2024

GitHub does not treat READMEs differently in means of how it stores them. The special meaning is just a convention.

Let's separate how a README is represented on Kitfile and how it is stored in a ModelKit.

IMHO we do not need a special construct on Kitfile to indicate something is a README. It is in the name already.

When storing as part of the ModelKit. I agree that we can make it easier for clients to render it. Browsers today already support Gzip encoding and the compression streams API can decompress gzip. I think we should do a PoC to see how easy it is to use them today before we make a change.

@brett-hodges brett-hodges self-assigned this Jun 21, 2024
@gorkem gorkem assigned amisevsk and unassigned brett-hodges Jun 24, 2024
@gorkem gorkem changed the title Add readme.md into the Kitfile / ModelKit Add a docs layer to ModelKits Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ModelKit Topics related to ModelKit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants