Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing on the get_unverified_header function #745

Closed
lindycoder opened this issue Apr 6, 2022 · 6 comments
Closed

Typing on the get_unverified_header function #745

lindycoder opened this issue Apr 6, 2022 · 6 comments
Labels
good first issue help wanted stale Issues without activity for more than 60 days

Comments

@lindycoder
Copy link

Hello, thank you for the tool!

It seems the get_unverified_header is missing types to use in a strict mypy configuration!

https://github.com/jpadilla/pyjwt/blob/master/jwt/api_jws.py#L202

If I am not mistaken, this might do it:

def get_unverified_header(self, jwt: str) -> Dict[str, Any]:
@lindycoder
Copy link
Author

Actually based on what _load takes, jwt should be a Union[str, bytes]

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label Jun 6, 2022
@lindycoder
Copy link
Author

Removing stale just waiting for a maintainer to comment if this issue is valid or not.

@jpadilla jpadilla added help wanted good first issue and removed stale Issues without activity for more than 60 days labels Jun 7, 2022
@jpadilla
Copy link
Owner

jpadilla commented Jun 7, 2022

lgtm, can you open a PR?

@lindycoder
Copy link
Author

Thanks, I might look into it, might take a couple weeks though, pretty busy

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted stale Issues without activity for more than 60 days
Projects
None yet
Development

No branches or pull requests

2 participants