You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A long standing todo list item for this project is to refactor the header layouts to reduce the code repetition between the various layouts. Currently the hybrid layout duplicates the code from basic and hamburger and leads to issues when they are not kept in parity.
There's also potential to extract parts of the logic into functions so they can be reused in a more generic way. This would then allow more header layouts to be created without the overhead of maintaining support for existing features in every layout.
I'm creating this as an issue in case there's anyone in the community who has the time to look at submitting a PR for this change.
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had any recent activity.
If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open.
This issue will automatically close in 30 days if no further activity occurs.
A long standing todo list item for this project is to refactor the header layouts to reduce the code repetition between the various layouts. Currently the
hybrid
layout duplicates the code frombasic
andhamburger
and leads to issues when they are not kept in parity.There's also potential to extract parts of the logic into functions so they can be reused in a more generic way. This would then allow more header layouts to be created without the overhead of maintaining support for existing features in every layout.
I'm creating this as an issue in case there's anyone in the community who has the time to look at submitting a PR for this change.
The text was updated successfully, but these errors were encountered: