Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logoDark & logo parameters reversed in hybrid header layout with defaultAppearance set to "dark" #939

Open
socrabytes opened this issue Sep 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@socrabytes
Copy link
Contributor

Issue description

In config file params.toml, the header.logo and header.logoDark parameters seem to be swapped. The dark mode logo appears in light mode and vice versa. The only customization I’ve made is setting defaultAppearance = "dark" instead of the default "light", which might be related to the issue. Otherwise, no significant customizations come to mind.

defaultAppearance = "dark" 
autoSwitchAppearance = true

[header]
  layout = "hybrid" 
  logo = "img/logo-dark.png" # Bug: theme improperly handling logo versions of light/dark
  logoDark = "img/logo.png" 

This is a minor issue, but I thought it would be helpful to report it. Thank you for providing this theme and for all the effort you’ve put into maintaining it!

Theme version

v2.9.0

Hugo version

hugo v0.134.3+extended linux/amd64

Which browser rendering engines are you seeing the problem on?

Chromium (Google Chrome, Microsoft Edge, Brave, Vivaldi, Opera, etc.)

URL to sample repository or website

https://github.com/socrabytes/socrabytes.github.io

Hugo output or build error messages

N/A
@socrabytes socrabytes added the bug Something isn't working label Sep 22, 2024
@Jh123x
Copy link
Contributor

Jh123x commented Sep 24, 2024

Issue description

In config file params.toml, the header.logo and header.logoDark parameters seem to be swapped. The dark mode logo appears in light mode and vice versa. The only customization I’ve made is setting defaultAppearance = "dark" instead of the default "light", which might be related to the issue. Otherwise, no significant customizations come to mind.

defaultAppearance = "dark" 
autoSwitchAppearance = true

[header]
  layout = "hybrid" 
  logo = "img/logo-dark.png" # Bug: theme improperly handling logo versions of light/dark
  logoDark = "img/logo.png" 

This is a minor issue, but I thought it would be helpful to report it. Thank you for providing this theme and for all the effort you’ve put into maintaining it!

Theme version

v2.9.0

Hugo version

hugo v0.134.3+extended linux/amd64

Which browser rendering engines are you seeing the problem on?

Chromium (Google Chrome, Microsoft Edge, Brave, Vivaldi, Opera, etc.)

URL to sample repository or website

https://github.com/socrabytes/socrabytes.github.io

Hugo output or build error messages

N/A

Does the issue still occur if the default appearance is not dark mode?

@socrabytes
Copy link
Contributor Author

Yes, theme displays same behavior with defaultAppearance = "light"


I’ve also noticed something strange in Vivaldi when Windows is set to Dark Mode and the site’s default appearance is also dark. The background color doesn’t display correctly, and it looks off.

In Brave, everything works as expected — the site loads in dark mode and toggles properly to light mode. But in Vivaldi, it starts in this weird, mismatched dark mode and only switches to the correct one after toggling. This might just be a quirk with how browsers handle dark mode, but it’s still an edge case worth pointing out.

image

Note: The logo is currently a PNG, not an SVG, which is contributing to the display issue. Using a proper vector (SVG) logo would likely resolve this specific problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants