Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling auto-retry spams out warnings #132

Closed
advance512 opened this issue Dec 18, 2022 · 2 comments
Closed

Disabling auto-retry spams out warnings #132

advance512 opened this issue Dec 18, 2022 · 2 comments

Comments

@advance512
Copy link
Contributor

According to the documentation:

# Retrying API Calls

By default, hubspot3 will attempt to retry all API calls up to 2 times
upon failure.

If you'd like to override this behavior, you can add a `number_retries`
keyword argument to any Client constructor, or to individual API calls.

However, setting number_retries=0 causes the library to spam out warnings on the first failure, e.g.

Too many retries for /deals/v1/deal/110248399499?
Too many retries for /deals/v1/deal/102249436582?
Too many retries for /deals/v1/deal/102351008917?

When disabling the auto-retry mechanism it is expected that the library will not auto-retry, and will not output anything in regards to retrying.

Can we disable this warning in case of number_retries==0?

@advance512
Copy link
Contributor Author

Added PR: #133

@jpetrucciani
Copy link
Owner

The fix is included in version 3.2.52 on pip! Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants