Skip to content
This repository has been archived by the owner on Apr 3, 2022. It is now read-only.

Logger is not able to match stackLine #10

Open
simonihmig opened this issue Sep 13, 2020 · 1 comment
Open

Logger is not able to match stackLine #10

simonihmig opened this issue Sep 13, 2020 · 1 comment

Comments

@simonihmig
Copy link
Contributor

stackLine was at <program> (test.js:3) in my case., which did not match the regex in https://github.com/jpg0/ohj/blob/master/log.js#L60, and was throwing therefore (see #9)

On first look:

  • the regex seems to expect a :lineNumber:columnNumber ending, which was not the case for me
  • it seems to use named capture groups, which are a proposed ECMAScript extension, not sure if GraalVM really supports these already?
@jpg0
Copy link
Owner

jpg0 commented Sep 14, 2020

The challenge here has been the GraalJS has not stuck with the same format across versions, and also I think I have seen slightly different formatting at points with the same version (possibly based on whether and how it locates the source file).

It should support named capture groups though, pretty sure it has worked!

I regard this parsing part as needed a rewrite though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants