Skip to content

Subsequence match merging: implement minimum number of merges #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tsaglam opened this issue Nov 22, 2024 · 1 comment · Fixed by #2188
Closed

Subsequence match merging: implement minimum number of merges #2077

tsaglam opened this issue Nov 22, 2024 · 1 comment · Fixed by #2188
Assignees
@tsaglam
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Milestone
6.0.0

Comments

@tsaglam
Copy link
Member

tsaglam commented Nov 22, 2024

After merging each comparison, we should check the number of neighboring matches merged. When this number is below a threshold, the merged matches should be dropped and the original ones used. This safeguard reduces the impact on pairs or unrelated programs.
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Nov 22, 2024
@tsaglam tsaglam self-assigned this Nov 22, 2024
@tsaglam tsaglam changed the title Subsequence match merging: implement minimum number of merges. Subsequence match merging: implement minimum number of merges Nov 22, 2024
@tsaglam tsaglam added this to the 6.0.0 milestone Jan 23, 2025
@tsaglam tsaglam mentioned this issue Feb 14, 2025
Merged
5 tasks
@tsaglam tsaglam linked a pull request Feb 14, 2025 that will close this issue
Enforce minimum merges when using match merging. #2188
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Closed by #2188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsaglam tsaglam

Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Enforce minimum merges when using match merging. jplag/JPlag
1 participant
@tsaglam