Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating slave zones does not work #4

Open
Habbie opened this issue May 7, 2018 · 1 comment
Open

creating slave zones does not work #4

Habbie opened this issue May 7, 2018 · 1 comment
Labels

Comments

@Habbie
Copy link
Contributor

Habbie commented May 7, 2018

In def zone_exists:

    if info['status'] == 422:  # not found
        return None

but since PowerDNS/pdns@77bfe8d, the API uses 404 to indicate domain not found.

Furthermore, the code just above (url = "{0}/{1}".format(base_url, zone)) does not take into account the (intentionally unspecified) encoding the API uses for zone names in URLs. I am unsure there is an official way to check for presence of a zone, other than listing all zones.

@jpmens jpmens added the bug label May 7, 2018
@jpmens
Copy link
Owner

jpmens commented May 7, 2018

As I think you're indicating: this used to work pre API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants