Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom:link in RSS feed should point to self, not atom #113

Closed
datashaman opened this issue Jan 15, 2020 · 2 comments · Fixed by #122
Closed

atom:link in RSS feed should point to self, not atom #113

datashaman opened this issue Jan 15, 2020 · 2 comments · Fixed by #122

Comments

@datashaman
Copy link

datashaman commented Jan 15, 2020

Describe the bug
Somewhat counter-intuitively, the atom:link URL should point to the RSS feed, not the Atom feed.

See http://www.rssboard.org/rss-profile#namespace-elements-atom
and
https://www.feedvalidator.org/docs/warning/MissingAtomSelfLink.html

To Reproduce

Create an RSS feed.

Expected behavior

RSS feed must include an atom:link element with rel="self" attribute which points to the RSS feed.

Actual behavior

RSS atom:link erroneously points to the Atom feed.

Versions (please complete the following information):

  • NodeJS: node v10.17.0
  • TypeScript: n/a
  • npm/yarn: npm 6.13.4
  • feed: 2.0.4
@datashaman
Copy link
Author

From examining the code, it looks like you can override this by setting options.feed to the URL of your RSS feed. The default strategy of including the Atom link is still incorrect though.

@datashaman
Copy link
Author

Although doing that makes the Atom feed invalid, because it now points to the RSS feed as self. Sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant