-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validateURL is not nice function #23
Comments
Yup. To add to this, it would at least be handy for the error to indicate which of the potentially hundreds of links is invalid. It would be nice to change it to this:
... to this:
|
It also seems to fail, even on valid urls such as:
A suggestion could be to use the validator module: https://www.npmjs.com/package/validator Or pick up their version of url validation: https://github.com/chriso/validator.js/blob/master/validator.js#L200-L260 |
+1 |
Fixed in 761272c? |
Removed validation on URL - developer is free to write them valid. |
I mean it possible problems for local hostname like http://myworknotebook etc
The text was updated successfully, but these errors were encountered: