npm package broken

[leider]

Describe the bug
The current npm release exposes a typescript class not a javascript class

To Reproduce
Steps to reproduce the behavior:

1. Create a pure javascript nodejs file
2. require feed
3. try to instantiate the Feed class
4. See error

Expected behavior
Works as before

Actual behavior
Kills server

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• NodeJS: 10
• TypeScript: none
• npm/yarn: 5.6.0 (npm)
• feed: latest

Additional context
None

[jpmonette]

@leider Can you provide code sample please?

[leider]

What exactly is not clear in the bug description?

…

Am 10.09.2018 um 00:55 schrieb Jean-Philippe Monette ***@***.***>: @leider Can you provide code sample please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jpmonette]

@leider There's no such thing as a TypeScript class - the code is compiled to JavaScript in the lib directory by tsc.

My assumption here (without the code sample you are trying to run) is that you are trying to import the module using a require() instead of an import.

Considering the latest version of feed is now using named imports using the ES6 module syntax, you must import the module as described in the README:

import { Feed } from 'feed';

If you want to stick with the old approach, you should be able to do the following:

const Feed = require('feed').Feed;

As I'm not sure if this was the situation you were facing, please confirm if this solves your issue.

[leider]

Thanks. This is the situation. I will try as soon as I can and give feedback.

…

Am 10.09.2018 um 23:58 schrieb Jean-Philippe Monette ***@***.***>: @leider There's no such thing as a TypeScript class - the code is compiled to JavaScript in the lib directory by tsc. My assumption here (without the code sample you are trying to run) is that you are trying to import the module using a require() instead of an import. Considering the latest version is now using named imports, in ES6, you import it as described in the README: import { Feed } from 'feed'; If you want to stick with the old way of importing modules, you should be able to do the following: const Feed = require('feed').Feed; As I'm not sure if this was the situation you were facing, please confirm if this solves your issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[leider]

Checked it. Thanks for the clarification. Problem was me not understanding excatly what was the problem. Documentation fix is appreciated!

[melroy89]

const Feed = require('feed').Feed; line saved me 2 hours of my day. Please document this !