Freshly generated project has broken test on Windows

[Cono52]

Doesn't seem to be a problem on my Mac but decided to run on Windows in case everyone else wasn't.

I checked again, by pulling latest from master on both my machines -> rebuild -> re-add to global -> regenerate a test projects -> re-run tests

i guess it's related to jest dom not being added correctly?

[threepointone]

Oh hmm, yeah, looks like setupTests isn't being called properly.

[Cono52]

I found it's related to the globby in the craco.config.js used to find the setupTests.ts

modular/packages/modular-scripts/craco.config.js

Lines 88 to 91 in 510a876

	setupFilesAfterEnv: globby.sync(
	[`${absoluteModularGlobalConfigsPath}/setupTests.{js,ts,tsx}`],
	{
	cwd: process.cwd(),

seems globby has some catches on Windows and produces nothing when searching any patterns

sindresorhus/globby#155

will look into workarounds

[threepointone]

We could just not use globby here

modular/packages/modular-scripts/craco.config.js

Lines 88 to 89 in 510a876

	setupFilesAfterEnv: globby.sync(
	[`${absoluteModularGlobalConfigsPath}/setupTests.{js,ts,tsx}`],

maybe like...

["setupTests.js", "setupTests.ts", "setupTests.tsx"]
  .map((p) => path.join(absoluteModularGlobalConfigsPath, p))
  .filter((p) => fs.existsSync(p));

[threepointone]

We should also run our CI tests on windows, I'll look into that later.

[Cono52]

Your code sliced worked in the above case but it was handy to keep some globing to keep giving those nice warnings about other "setupTests" files that might be found somewhere randomly in the package i.e.

modular/packages/modular-scripts/craco.config.js

Lines 72 to 78 in 510a876

	console.warn(
	"A setupTests file was found within an app's `src/` directory:",
	perPackageSetupTests.join(', '),
	);
	console.warn(
	'Modular projects should store all test setup at the root of the project (e.g. `modular/setupTests.{js,ts,tsx}`).',
	);