Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to build a custom component using Salt theme #3847

Open
1 task done
origami-z opened this issue Jul 18, 2024 · 11 comments · May be fixed by #4054
Open
1 task done

Document how to build a custom component using Salt theme #3847

origami-z opened this issue Jul 18, 2024 · 11 comments · May be fixed by #4054
Assignees
Labels
adopter: strategic product package: theme Theme package type: documentation Improvements or additions to documentation type: enhancement 💡 New feature or request

Comments

@origami-z
Copy link
Contributor

Area

Documentation

The problem

User often needs to create custom components to play nicely with Salt components, currently it's very hard to navigate the "how"

The solution

Document how to use existing tokens to create custom components, using some representative tokens (e.g. background, foreground, spacing, size). Improve theming / characteristics documentation (token page) may also be needed.

Alternatives and examples

.

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: documentation Improvements or additions to documentation type: enhancement 💡 New feature or request package: theme Theme package adopter: strategic product labels Jul 18, 2024
@joshwooding
Copy link
Contributor

@origami-z will this replace #2576?

@origami-z
Copy link
Contributor Author

@origami-z will this replace #2576?

Not entirely the same. Don't know what to do with #2576, but this likely will be a new page under theming

@origami-z origami-z self-assigned this Jul 22, 2024
@mark-tate
Copy link
Contributor

Goal: publish by EOS

@origami-z
Copy link
Contributor Author

25 Jul - starting today with a draft

@mark-tate
Copy link
Contributor

Cortado Goal: Review Docs and publish

@origami-z
Copy link
Contributor Author

Aug 12 - #3898 to be reviewed

@mark-tate
Copy link
Contributor

Espresso Goal, page to be published

@origami-z
Copy link
Contributor Author

Posted on internal stack overflow questions/90695

@joshwooding joshwooding reopened this Sep 5, 2024
@joshwooding joshwooding linked a pull request Sep 5, 2024 that will close this issue
@mark-tate
Copy link
Contributor

Frappe Goal: reviewed/discussed and published

@mark-tate
Copy link
Contributor

to be reviewed

@mark-tate
Copy link
Contributor

move to backlog util we can refine better the scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: strategic product package: theme Theme package type: documentation Improvements or additions to documentation type: enhancement 💡 New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants