Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct export in TS definition #18

Open
websitevirtuoso opened this issue Oct 11, 2023 · 1 comment
Open

Correct export in TS definition #18

websitevirtuoso opened this issue Oct 11, 2023 · 1 comment

Comments

@websitevirtuoso
Copy link

I started to use bun by many reasons. and first notices that it throw error

viktord@blade:~/Projects/renthome/dashboard$ bun run build
$ vite build
vite v4.4.11 building for production...
✓ 1858 modules transformed.
✓ built in 8.21s
"getter" is not exported by "node_modules/property-expr/index.js", imported by "node_modules/yup/index.esm.js".
file: /home/viktord/Projects/renthome/dashboard/node_modules/yup/index.esm.js:1:9
1: import { getter, forEach, split, normalizePath, join } from 'property-expr';
            ^
2: import { camelCase, snakeCase } from 'tiny-case';
3: import toposort from 'toposort';
error during build:
RollupError: "getter" is not exported by "node_modules/property-expr/index.js", imported by "node_modules/yup/index.esm.js".
    at error (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:2287:30)
    at Module.error (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:13745:16)
    at Module.traceVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:14175:29)
    at ModuleScope.findVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:12615:39)
    at ChildScope.findVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at ClassBodyScope.findVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at ChildScope.findVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at FunctionScope.findVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at ChildScope.findVariable (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:7124:38)
    at Identifier.bind (file:///home/viktord/Projects/renthome/dashboard/node_modules/vite/node_modules/rollup/dist/es/shared/node-entry.js:8319:40)
error: script "build" exited with code 1 (SIGHUP)

image

I am also using nodejs v20
I think we already have PR to fix it
https://github.com/jquense/expr/pull/16/files
How can I assist to merge this PR?

@seamuslowry
Copy link

Did you ever find a fix for this? The merged PR is in, but this error seems to come from the index.js not a TS definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants