Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top part of a 24 hour event in Week/Day View is hidden behind column header #1646

Closed
Khanbhai1990 opened this issue Apr 30, 2020 · 7 comments

Comments

@Khanbhai1990
Copy link

Khanbhai1990 commented Apr 30, 2020

Do you want to request a feature or report a bug?

This is a bug I come across

What's the current behavior?

top part of a 24 hour event in Week/Day View is hidden behind column header. Which in turn is hiding the 'start' and 'end' of the event. I have "showMultiDayTimes" as true.
Screen Shot 2020-04-30 at 3 01 34 PM

What's the expected behavior?

top in css should be 0% instead of being -2.08333%

@Khanbhai1990
Copy link
Author

if I remove deselect 'top' you can see the top half of the event is visible.
Screen Shot 2020-04-30 at 3 29 57 PM

@Khanbhai1990
Copy link
Author

Khanbhai1990 commented May 1, 2020

After further investigation I found that events that end after 11:30pm have the 'top' percentage calculated incorrectly
event ending before 11:30pm
Screen Shot 2020-05-01 at 4 26 03 PM
same event ending after 11:30pm. Even though the event should start at 8:00pm according to the label. The top calculation is showing the event as if its starting 30 mins earlier.
Screen Shot 2020-05-01 at 4 26 36 PM

@Khanbhai1990
Copy link
Author

@jquense
hey bro,
would love to know if this is an actual bug or something wrong with my setup. I have exhausted all my options to fix this issue related to events being bumped up 30 mins (if they end after 11:30p) but label showing different time.

@jquense
Copy link
Owner

jquense commented May 6, 2020

Seems like it might be a bug. If you can reproduce it in a simple example that would help

@Khanbhai1990
Copy link
Author

Khanbhai1990 commented May 6, 2020

@jquense
bug for sure. I was able to replicate both issues in sandbox
https://codesandbox.io/s/eloquent-allen-bxnjm?file=/src/events.js

@jquense
Copy link
Owner

jquense commented May 6, 2020

happy to take a PR! I'm not sure what introduced this

@Khanbhai1990
Copy link
Author

@jquense
seems like the bug developed in 0.24.1
not sure if Im the right guy to make a PR as I'm new to the code base and this seems like a complicated issue involving event div size calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants