Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #1891
The code aims to standardize how Array and Tuple inner types are configured. Historically
array
has stored it's one inner type on a propinnerType
. Tuple has stored its types inspec.types
. The types MUST be stored on thespec
object for Tuple because it is needed for thenotType
method. See:yup/src/locale.ts
Line 137 in f37a53f
Both Array and Tuple now have
schema.innerType
andschema.spec.innerType
. This was done for backwards compatibility and consistency. And all corresponding methods and types have been updated.This now allows the Tuple to return information about its types in the
describe
methodLet me know if you have any questions!