-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function test names to email and url #292
Conversation
why close this? |
Honestly, I thought I did something wrong (this is my first PR changing code) so I closed it out of embarrassment. |
Nah, looks great, thanks for the PR, I'm a bit short on time, but I'll get to reviewing it more throughly! |
|
…nction Co-Authored-By: Jason Quense <monastic.panic@gmail.com>
@jquense do you have a schedule for publishing a new version of yup to npm? I'm relying on this patch in one of my projects, so I've included the yup master branch for now. It would be great to be able to use yup from npm. Happy to help if there is anything I can do 🙂. Thank you for this very useful lib! |
Thanks for tackling this @aytee17, I just noticed this too and was about to open a PR. Glad to see this got merged, and eagerly awaiting its release. Our system logs the |
I noticed that
string.email()
andstring.url()
don't have associated test function names and appear asundefined
in thetests
array ofSchemaDescription
.This just makes sure that a proper name is sent through the
matches
function.