Fix array path resolve for descendants #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Oct 23, 2019
src/array.js
Outdated
| const castElement = this._subType.cast(v, _opts); | ||
| const castArray = value.map((v, idx) => { | ||
| var path = makePath`${_opts.path}[${idx}]`; | ||
| var innerOptions = { |
There was a problem hiding this comment.
can you move this inline below: cast(v, { ..._opts, path: makePat
There was a problem hiding this comment.
Thanks for quick check @jquense ! Made the change.
jquense
approved these changes
Oct 24, 2019
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment during casting process Array type passes the field path to sub items without resolving it according to sub item array index.
The path is exposed to end consumer as part of context in conditional validation
when(could be somewhere else).If conditional validation relies on context path - this behaviour will lead to bugs.