add isTrue and isFalse checks on boolean
#910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
May 27, 2020
src/boolean.js
Outdated
| isFalse(message = locale.isFalse) { | ||
| return this.test({ | ||
| message, | ||
| name: 'isFalse', |
There was a problem hiding this comment.
the exclusive flag doesn't do anything unless there is another test with the same name. So you want to name both of this something like is-value, then bool().isFalse().isTrue() will only use the last isTrue, instead of creating an unmatchable schema
There was a problem hiding this comment.
Oh, I see. I updated it according to your suggestion
src/locale.js
Outdated
| export let boolean = {}; | ||
| export let boolean = { | ||
| isTrue: '${path} field must be true', | ||
| isFalse: '${path} field must be false', |
There was a problem hiding this comment.
you can get away with one message here: isValue: '${path} field must be ${expected}', by adding the expected value to the test params`
|
I think this PR is good to go. Let's merge it? |
jquense
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #904 :)