Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links and markup don't inherit the table face #716

Closed
angrybacon opened this issue Jul 1, 2022 · 1 comment
Closed

Links and markup don't inherit the table face #716

angrybacon opened this issue Jul 1, 2022 · 1 comment

Comments

@angrybacon
Copy link

Expected Behavior

I should be able to change the font-size for tables including their content eg. links.

Actual Behavior

Customizations to the markdown-table-face are overwritten by markdown-link-face and markdown-reference-face inside tables.

Steps to Reproduce

Create a simple table with links in the cells

| Links                        |
|------------------------------|
| [Link 1](https://github.com) |
| [Link 2][link-reference]     |
  1. ✔️ M-x describe-char on Links, blank spaces and separators correctly gives markdown-table-face
  2. ✔️ M-x describe-char on Link 1 correctly gives (markdown-table-face markdown-link-face)
  3. M-x describe-char on https://github.com incorrectly gives markdown-url-face
  4. M-x describe-char on Link 2 incorrectly gives markdown-link-face
  5. M-x describe-char on link-reference incorrectly gives markdown-reference-face
  6. M-x describe-char on [, ], ( and ) incorrectly gives markdown-markup-face

Software Versions

  • Markdown Mode: markdown-mode, version 2.6-dev
  • Emacs: GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin20.6.0, NS appkit-2022.60 Version 11.6 (Build 20G165)) of 2022-05-12
  • OS: macOS Big Sur
@angrybacon
Copy link
Author

angrybacon commented Jul 7, 2022

@syohex Hello 👋 thanks for the quick fix!

Unfortunately this only fixes the issue for links in tables. The markup characters still don't get proper inheritance ie. in the sample table I put above, I'm referring the following:

6. ❌ M-x describe-char on [, ], ( and ) incorrectly gives markdown-markup-face

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants