Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw an error for cid: URLs #21

Closed
takkaria opened this issue Jun 11, 2016 · 3 comments
Closed

Don't throw an error for cid: URLs #21

takkaria opened this issue Jun 11, 2016 · 3 comments

Comments

@takkaria
Copy link

cid: URLs are used to reference attached images in emails.

Current behaviour
web-resource-inliner throws an error for cid: URLs.

Expected behaviour
Ignore cid: URLs in img tags.
@jrit
Copy link
Owner

jrit commented Jun 11, 2016

Would this be resolved by ignoring src attributes when the value starts with cid:?

@takkaria
Copy link
Author

I think that would work fine, yes.

@SamuelTilly SamuelTilly mentioned this issue Jun 30, 2016
Closed
@jrit
Copy link
Owner

jrit commented Nov 17, 2016

should be fixed in eb84e0b with release coming soon

@jrit jrit closed this as completed Nov 17, 2016
@takkaria takkaria mentioned this issue Nov 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takkaria @jrit