feat: added snow #71
feat: added snow #71
Conversation
| startSnowflakes(); | ||
| }); | ||
|
|
||
| const getCanvasElementById = (id: string): HTMLCanvasElement => { |
There was a problem hiding this comment.
useCallback hook for function creation
| return canvas; | ||
| }; | ||
|
|
||
| const getCanvasRenderingContext2D = (canvas: HTMLCanvasElement): CanvasRenderingContext2D => { |
There was a problem hiding this comment.
useCallback hook for function creation
| return context; | ||
| }; | ||
|
|
||
| function startSnowflakes() { |
There was a problem hiding this comment.
useCallback hook for function creation
| const requestId = React.useRef(0); | ||
|
|
||
| useEffect(() => { | ||
| startSnowflakes(); |
There was a problem hiding this comment.
you can create useSnowflakes hook and incapsulate all logic inside
|
|
||
| const MAIN_YELLOW = '#F2E14C'; | ||
|
|
||
| const useStyles = makeStyles({ |
There was a problem hiding this comment.
please create useStyles variable outside component, otherwise this variable will be create on each component Render
|
|
||
| return ( | ||
| <> | ||
| <div className='snow-switcher'> |
There was a problem hiding this comment.
please use styles that you created by makeStyles, the same for all className
| @@ -0,0 +1,18 @@ | |||
| #snow { | |||
There was a problem hiding this comment.
please relocate styles to makeStyles function
| @@ -0,0 +1,31 @@ | |||
| @media screen and (min-width: 960px) { | |||
There was a problem hiding this comment.
you can add media by css-in-js, please relocate it inside makeStyles function,
if you need an example, you can find code with 'theme.breakpoints.'
No description provided.