Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootiso writes to incorrect folder when using wimlib-imagex #43

Closed
Ill1 opened this issue Feb 11, 2019 · 6 comments
Closed

Bootiso writes to incorrect folder when using wimlib-imagex #43

Ill1 opened this issue Feb 11, 2019 · 6 comments
Assignees
Labels
bug Something isn't working retrocompatibility upstream-bug A bug caused by third party solutions

Comments

@Ill1
Copy link

Ill1 commented Feb 11, 2019

Wimlib-imagex searches for the first dot and puts a number behind it to generate successive image splits.
The bootiso scripts generates mount points with dots in the folder names.
This causes the script to fail when using wimlib-imagex because it tries to write the second, third and fourth... files to the wrong temporary folder (mount points).

@jsamr
Copy link
Owner

jsamr commented Feb 11, 2019

@Ill1 Thanks for your feedback.
I have successfully used and tested the wimsplit feature with wimlib 1.13.0, before releasing.

Can you give me your system information (neofetch) + wimlib version to help investigate this issue.

Also, it would be nice of you to use a title which express the issue you encountered instead of the suggested solution, so that I can mark it as bug.

@Ill1
Copy link
Author

Ill1 commented Feb 12, 2019

@jsamr Sure:
wimlib-imagex (distributed with wimlib 1.12.0)
Copyright (C) 2012-2017 Eric Biggers

Kernel: 4.15.0-45-generic
Shell: bash 4.4.19
DE: GNOME 3.28.3
WM: GNOME Shell
Terminal: gnome-terminal

Apologies for including the how-to-fix rather than what-was-broken - The fix worked for me on local, I initially tried to setup a Pull Request with the same.

@Ill1 Ill1 changed the title Replace dot for dash in temporary folder names when using wimlib Bootiso writes to incorrect folder when using wimlib-imagex Feb 12, 2019
@jsamr
Copy link
Owner

jsamr commented Feb 12, 2019

@Ill1 OK. You are describing a wimlib bug, corrected in 1.13, which has a nasty side effect on bootiso!
From their changelog:

wimsplit (API: wimlib_split()) now correctly handles a dot in the path to the first split WIM part, prior to the filename extension.

So I'll publish a patch to have retro-compatibility with earlier versions of wimsplit.

@jsamr jsamr self-assigned this Feb 12, 2019
@jsamr jsamr added bug Something isn't working upstream-bug A bug caused by third party solutions retrocompatibility labels Feb 12, 2019
@Ill1 Ill1 closed this as completed Feb 12, 2019
@Ill1
Copy link
Author

Ill1 commented Feb 12, 2019

Thanks @jsamr

@jsamr
Copy link
Owner

jsamr commented Feb 12, 2019

@Ill1 I'll keep it open until released for others stumbling on this :-)

@jsamr
Copy link
Owner

jsamr commented Apr 4, 2019

Should be fixed in v3.3.0, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working retrocompatibility upstream-bug A bug caused by third party solutions
Projects
None yet
Development

No branches or pull requests

2 participants