Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to some Javascript styling guide #96

Open
adam-beck opened this issue Jun 5, 2014 · 2 comments
Open

Conform to some Javascript styling guide #96

adam-beck opened this issue Jun 5, 2014 · 2 comments
Labels

Comments

@adam-beck
Copy link

I've noticed that there are several places where there seems to be discrepancies between styles in the codebase. For instance, some places we have a single var statement while in others we have multiple. I've also noticed that there are inline var statements inside of for loops.

Would it be a good idea to have someone clean up the codebase in order to follow some general style? I understand working with in an open source everybody codes based on their preferences, but it would be nice to have some uniformity.

Along these same lines, maybe we could introduce jslint into the project?

@ChrisMcKenzie
Copy link
Collaborator

I agree, I think a .jshintrc would take care of this

@qfox
Copy link

qfox commented Sep 24, 2014

You should look at jscs. It's a great and simple tool to check code styles. It requires valid js so it should be executed after jshint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants