feat(options): adds parsing of options #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reworks the logic in layout service in order to make it easier to understand. The inital logic was pulled from angular-json-schema-form, but was proving to be difficult to follow as more functioanlity was added. This will hopefully break up the code a bit and make it more readable and maintainable
Merges a few schema props into layout options as well as copying extra layout layout props into layout options. Mimics angular-json-schema-form
jscharett
commented
Jul 16, 2019
jscharett
commented
Jul 16, 2019
jscharett
commented
Jul 16, 2019
jscharett
commented
Jul 16, 2019
jscharett
commented
Jul 16, 2019
jscharett
commented
Jul 16, 2019
projects/ngx-json-schema-form/src/lib/widget-library/input/button/button.component.html
Outdated
Show resolved
Hide resolved
jscharett
commented
Jul 16, 2019
projects/ngx-json-schema-form/src/lib/widget-library/input/hidden/hidden.component.html
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## development #9 +/- ##
===============================================
+ Coverage 94.37% 95.02% +0.64%
===============================================
Files 15 16 +1
Lines 231 241 +10
Branches 33 29 -4
===============================================
+ Hits 218 229 +11
Misses 6 6
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to set various attributes on the form tag as well as passing in various options to a layout item. Layout options mixin a few schema properties like readOnly, but specifying in the layout can override any schema value, giving the user better control.