Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing commit messages instead of using a new one #656

Open
xvs32x opened this issue Feb 7, 2023 · 2 comments
Open

Reusing commit messages instead of using a new one #656

xvs32x opened this issue Feb 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@xvs32x
Copy link

xvs32x commented Feb 7, 2023

Hi!
First of all, thank you for this amazing NX plugin! :)

I have NX monorepo with two apps and one shared library with module which is used by both of applications. The plugin let me to use --trackDeps option to bump versions of applications if I change something in my shared library. But I found a small issue related to the tags which were created after these changes.

For instance, I've got 2 last tags of my applications in Gitlab:

  • app1-1.0.0 - JIRA-1 Commit header example
  • app2-1.0.0 - JIRA-2 Commit header example

And then I change somethings, add commit message "JIRRA-3 Commit header example" in my library and release the changes. The plugin bumps versions of applications and create two tags with correct versions:

  • app1-1.0.1 - JIRA-1 Commit header example
  • app2-1.0.1 - JIRA-2 Commit header example

But, unfortunately it reuses the last commit for every application instead of using a new one.
So, in my case, it should be something like that:

  • app1-1.0.1 - JIRA-3 Commit header example
  • app2-1.0.1 - JIRA-3 Commit header example

I was really confused when I found a lot of tags with the same commit message =)

@xvs32x xvs32x changed the title Reusing commits messages instead of using a new one Reusing commit messages instead of using a new one Feb 7, 2023
@edbzn
Copy link
Member

edbzn commented Feb 7, 2023

Hi, the trackDeps option is fragile and hard to maintain in its current state cf #526, we started to rewrite @jscutlery/semver to correctly handle releasing workspace with apps and shared libraries, but this needs a full rewrite so unfortunately it won't land tomorrow.

@edbzn edbzn added the bug Something isn't working label Feb 7, 2023
@xvs32x
Copy link
Author

xvs32x commented Feb 8, 2023

Hi, the trackDeps option is fragile and hard to maintain in its current state cf #526, we started to rewrite @jscutlery/semver to correctly handle releasing workspace with apps and shared libraries, but this needs a full rewrite so unfortunately it won't land tomorrow.

Let me know if I can help you to speed up this rewriting. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants