Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new packages to Dockerfile #19

Merged
merged 2 commits into from
Mar 30, 2022
Merged

fix: add new packages to Dockerfile #19

merged 2 commits into from
Mar 30, 2022

Conversation

jimaek
Copy link
Member

@jimaek jimaek commented Mar 30, 2022

I know we dont support them yet but since we assume users will rarely pull new Docker containers we will run into an issue where once we add support for them none of existing probes will be able to run them because there wont be a binary present.
So we should add all the binaries we might need right now. This way even the oldest probes will have them and will work fine after the code auto-update.

Am I missing any other packages?

@jimaek jimaek requested a review from zarianec March 30, 2022 13:16
@zarianec
Copy link
Contributor

zarianec commented Mar 30, 2022

maybe host in case we want to do something simple with DNS resolving and don't want to parse dig output?

@zarianec
Copy link
Contributor

Nevermind, host and nslookup are part of dnsutils package :)

@zarianec zarianec changed the title New packages fix: add new packages to Dockerfile Mar 30, 2022
@jimaek jimaek merged commit 763e042 into master Mar 30, 2022
@jimaek jimaek deleted the new-packages branch March 30, 2022 21:20
@github-actions
Copy link

🎉 This PR is included in version 0.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants