Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard link #251

Closed
alexey-yarmosh opened this issue Oct 4, 2024 · 4 comments · Fixed by #258
Closed

Add dashboard link #251

alexey-yarmosh opened this issue Oct 4, 2024 · 4 comments · Fixed by #258

Comments

@alexey-yarmosh
Copy link
Member

Let's add a message and link about the dashboard in the probe logs during boot.

@alexey-yarmosh alexey-yarmosh self-assigned this Oct 4, 2024
@MartinKolarik
Copy link
Member

If we do this, it'd be good to check if the probe is already adopted or not first.

@alexey-yarmosh
Copy link
Member Author

Ideally isAdopted field should be added to the Probe object. But I am not sure if that change should be added just to support conditional log message. Maybe we can show the message always? Or smth like that may be an alternative:
https://github.com/jsdelivr/globalping/compare/dashboard-link?expand=1

@MartinKolarik wdyt?

@MartinKolarik
Copy link
Member

https://github.com/jsdelivr/globalping/compare/dashboard-link?expand=1

This seems fine but I'd add it as a new event, no need to combine it with the location data.

Copy link

🎉 This issue has been resolved in version 0.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants