Bug in parsing URLs

[dzrdmwjx]

While playing with some jquery/ajax stuff in node.js, I think I’ve hit a bug in the whatwg-url module used by jsdom. It’s unable to parse certain valid URLs such as: "https://r3---sn-p5qlsnz6.googlevideo.com/" and throws "TypeError: Invalid URL". I think the problem is with the “r3---sn” part of the hostname.

jsdom version: 8.1.0
whatwg-url version: 1.0.1

Following node.js code reproduces the issue:

var url = "https://r3---sn-p5qlsnz6.googlevideo.com/";
parseURL = require("whatwg-url").parseURL;
var result = parseURL(url);

Output:

../node_modules/whatwg-url/lib/url-state-machine.js:1151
    throw new TypeError("Invalid URL");
    ^
TypeError: Invalid URL
    at Object.module.exports.basicURLParse (../node_modules/whatwg-url/lib/url-state-machine.js:1151:11)
    at module.exports.parseURL (../node_modules/whatwg-url/lib/url-state-machine.js:1189:25)
    at Object.<anonymous> (test.js:5:14)

[domenic]

Thanks; this is waiting on a spec resolution at whatwg/url#53 (comment).

[dzrdmwjx]

Wondering if there's an update on this issue...
If Google's Youtube CDN host names don't meet the spec, can you provide me a hint as to where exactly this check is implemented in the code? I'll try to tweak it in my installation to hopefully make it work with such URLs. Thanks!

[Sebmaster]

Seems like with the release of Unicode 9 this has been changed and these labels are now allowed. Will update soon-ish. If you can't wait, the validation is in the tr46 package.

[dzrdmwjx]

That was super-easy! Thanks a lot :)

[patrickhulce]

Any updates here? It's not clear to me how the line referenced in tr46 solves the issue with the above YouTube URLs as it's this check that seems to be the problem. The latest version of whatwg-url (4.7.0) still throws. There was a proposed allowHyphens option in the spec discussion that would skip this check. Can that be made available?

[TimothyGu]

This should be fixed in #100.

[Sebmaster]

Yup. Should be fixed with 6.2.0+.