Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: new option -i and -I to complement -e and -E #40

Open
malcook opened this issue Nov 25, 2019 · 6 comments
Open

Feature Request: new option -i and -I to complement -e and -E #40

malcook opened this issue Nov 25, 2019 · 6 comments

Comments

@malcook
Copy link

malcook commented Nov 25, 2019

During development of a pipeline involving Genrich for integrating ATAC seq with ChIP-Seq for multiple marks, I wish to only call peaks on a few small regions. For this reason, it is desirable to be able to specify which chromosomes or bed-regions to include.

The effective genome should then be the regions to include minus the regions to exclude.

This would allow me to tell Genrich to analyze, eg, chr8 only, minus any pre-computed global region black-list.

Finally, being able to specify chromosome to include or exclude using regular expression would be great. One useful expression would be `-i ^chr\d+$' to effectively remove (in the case of exnsembl zebrafish) chrM and an of the "unknown" chromosomal fragments matching "chrUn_*".

This feature would also simplify life for people seeking an easier way to #29.

@jsh58
Copy link
Owner

jsh58 commented Nov 29, 2019

Thanks for the suggestion. The reason why Genrich analyzes the whole genome by default, is because that is how these assays work. ATAC-seq, ChIP-seq, etc. are performed on whole genomes, not just certain chromosomes or regions.

Nevertheless, I will consider the request. In the meantime, please use -e and -E, and let me know if there are any issues with them.

@malcook
Copy link
Author

malcook commented Nov 29, 2019 via email

@ScottNortonPhD
Copy link

As a workaround, you can select the regions you want using bedtools intersect.

@jsh58
Copy link
Owner

jsh58 commented Jun 7, 2020

bedtools intersect is unlikely to produce the correct result in this context.

@j-andrews7
Copy link

A parameter to provide genome length directly would also be very helpful. We subset data frequently to run multiple different peak callers with various parameters to find the best settings for a given assay.

@jsh58
Copy link
Owner

jsh58 commented Mar 5, 2023

There is now a -L <int> CL argument that can be used to set the genome length directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants