Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change obj.hasOwnProperty to Object.hasOwn or Object.prototype.hasOwnPerperty.call #176

Closed
rktyt opened this issue Oct 7, 2024 · 1 comment · Fixed by #177
Closed

Change obj.hasOwnProperty to Object.hasOwn or Object.prototype.hasOwnPerperty.call #176

rktyt opened this issue Oct 7, 2024 · 1 comment · Fixed by #177

Comments

@rktyt
Copy link

rktyt commented Oct 7, 2024

v0.7.1

https://github.com/jshttp/cookie/blob/v0.7.1/index.js#L133

Here is an example where this is problematic.

require('cookie').parse('hasOwnProperty=str;xx=xx')
// Uncaught TypeError: obj.hasOwnProperty is not a function

This should not be the intended behavior.

@blakeembrey
Copy link
Member

Thanks, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants