Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase node version floor and cut new major once QUERY is supported? #27

Closed
jonchurch opened this issue Apr 29, 2024 · 3 comments
Closed

Comments

@jonchurch
Copy link
Member

jonchurch commented Apr 29, 2024

The fallback methods in https://github.com/jshttp/methods/blob/master/index.js#L22 do not encompass the new QUERY method.

We could use code to include it if the Node version you're running includes it, but I think a new major would be more appropriate if we have differences in http.METHODS between node majors. Not sure this has ever happened before.

See expressjs/express#5615

related: expressjs/express#5628

@dougwilson
Copy link
Contributor

dougwilson commented May 12, 2024

That list of methods in this module is only supposed to be the ones supported by Node.js 0.10. If you are going to make a ner major, drop 0.10 and remove that static list, as it is only needed for supprt Node.js 0.10. That is less stuff to maintain

@dougwilson
Copy link
Contributor

And at that point, why bother with the module, just use the http module exports directly in express and stuff. This module was only made for shimming Node.js 0.10 support

@jonkoops
Copy link

I think this can be closed considering we're dropping this module for Express v5, see #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants