Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid start and end byte ranges should return -2 #24

Open
mreinstein opened this issue Sep 26, 2022 · 4 comments
Open

invalid start and end byte ranges should return -2 #24

mreinstein opened this issue Sep 26, 2022 · 4 comments
Labels

Comments

@mreinstein
Copy link

Expected:

parse(200, 'bytes=x-100') === -2

Actual:

parse(200, 'bytes=x-100') === [ { start: 0, end: 199 }, type: 'bytes' ]
@JakeChampion
Copy link

@mreinstein is this bug fixed for you?

@dougwilson
Copy link
Contributor

dougwilson commented Nov 8, 2022

Hmm, i don't think it's fixed. The PR with the fix looks like it was closed too. Looks like the original pr came in while I was dealing with a hurricane and then there was a ping while I was on a work trip that I forgot to respond to. Not sure why they ended up closed now. I'll reopen this @JakeChampion and I think I can pluck the changes from that PR to master still.

@dougwilson dougwilson reopened this Nov 8, 2022
@mreinstein
Copy link
Author

@mreinstein is this bug fixed for you?

Not fixed. I was trying to get the PR through but didn't seem like there was any momentum or follow through. 10 months later, nothing has changed.

@wesleytodd
Copy link
Member

Hey @mreinstein, sorry this is a group of unpaid volunteers, please have patience. Would you be willing to re-open a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants