Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to reflect Issue #6 ? #12

Open
hallyn opened this issue Dec 1, 2021 · 0 comments
Open

Update README to reflect Issue #6 ? #12

hallyn opened this issue Dec 1, 2021 · 0 comments

Comments

@hallyn
Copy link
Contributor

hallyn commented Dec 1, 2021

Issue#6 points to PR#7 which is merged. However, that PR by itself doesn't fix the problem, it only allows the problem to be fixed.

The README still shows adding a key to the usersession keychain, and reading it from that. The keyring.Add should be updated to reflect this comment: #6 (comment) . That is, add the key to the session keyring, set the perms, link to usersession and unlink from session.

Without that, subsequent key.Get() will fail. With that, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant