Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for how many logs are kept: NUMBER_OF_LOGS_TO_KEEP #278

Merged
merged 2 commits into from
Jun 1, 2016

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Jun 1, 2016

Fix #277
cc @k-okada

@@ -45,7 +45,7 @@
<jenkins.model.BuildDiscarderProperty>
<strategy class="hudson.tasks.LogRotator">
<daysToKeep>3</daysToKeep>
<numToKeep>3</numToKeep>
<numToKeep>%(NUMBER_OF_LOGS_TO_KEEP)d</numToKeep>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env.get() returns string so this should be `%(NUMBER_OF_LOGS_TO_KEEP)d

@wkentaro
Copy link
Member Author

wkentaro commented Jun 1, 2016

Fixed.

@k-okada k-okada merged commit c3eb692 into jsk-ros-pkg:master Jun 1, 2016
@wkentaro wkentaro deleted the keep-log-option branch August 6, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants