-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default --no-status to CATKIN_TOOLS_BUILD_OPTIONS #297
Conversation
6f5d717
to
74f69c7
Compare
Why do you think so? Jenkins is also run in travis, and no output longer than 10min lead travis to be dead anyway.
Nice catch I created another PR to fix only this problem. |
Because the build on Jenkins does not need |
sorry need rebase.? |
This commit fixes belows: - Typo "ROS_DISTRO" should be "$ROS_DISTRO", but checking catkin-tools version is better. - Replace `--limit-status 0.002` with `--no-status` the status limit should be specified in .travis.yml like `export CATKIN_TOOLS_BUILD_OPTIONS="-iv --summarize --limit-status 0.001"`.
74f69c7
to
cdeef07
Compare
Rebased. |
For #296 (comment)
Could u please give me feedbacks? @furushchev @k-okada
This commit fixes belows:
version is better.
--limit-status 0.002
with--no-status
the status limitshould be specified in .travis.yml like
export CATKIN_TOOLS_BUILD_OPTIONS="-iv --summarize --limit-status 0.001"
.